benchmark: update function_args addon code #34725
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the code linter-conformant and remove usage of deprecated APIs.
nodejs-github-bot
added
the
build
github-actions
bot
removed
the
request-ci
|
CI: https://ci.nodejs.org/job/node-test-pull-request/32727/ (:green_heart:) |
richardlau
approved these changes
Aug 11, 2020
mscdex
added
benchmark
jasnell
approved these changes
Aug 11, 2020
addaleax
added
the
author ready
|
Minor enough to fast-track? |
|
Landed in bbdb013...420da0c |
jasnell
pushed a commit
that referenced
this pull request
Aug 11, 2020
Make the code linter-conformant and remove usage of deprecated APIs. PR-URL: #34725 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Aug 11, 2020
PR-URL: #34725 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 17, 2020
Make the code linter-conformant and remove usage of deprecated APIs. PR-URL: #34725 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 17, 2020
PR-URL: #34725 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Aug 20, 2020
Make the code linter-conformant and remove usage of deprecated APIs. PR-URL: #34725 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Aug 20, 2020
PR-URL: #34725 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax
added a commit
that referenced
this pull request
Sep 22, 2020
PR-URL: #34725 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
benchmark: update function_args addon code
Make the code linter-conformant and remove usage of deprecated APIs.
build: cover all benchmark addons with C++ linter
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes